Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EA398200D4F for ; Wed, 22 Nov 2017 00:42:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E8C1E160C0E; Tue, 21 Nov 2017 23:42:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3940E160BFC for ; Wed, 22 Nov 2017 00:42:03 +0100 (CET) Received: (qmail 44472 invoked by uid 500); 21 Nov 2017 23:42:02 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 44461 invoked by uid 99); 21 Nov 2017 23:42:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Nov 2017 23:42:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A3E05C3E26 for ; Tue, 21 Nov 2017 23:42:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.811 X-Spam-Level: X-Spam-Status: No, score=-99.811 tagged_above=-999 required=6.31 tests=[KB_WAM_FROM_NAME_SINGLEWORD=0.2, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id VOnf04wh1tUl for ; Tue, 21 Nov 2017 23:42:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D67945FBEA for ; Tue, 21 Nov 2017 23:42:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 66BA0E045B for ; Tue, 21 Nov 2017 23:42:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 23154255AA for ; Tue, 21 Nov 2017 23:42:00 +0000 (UTC) Date: Tue, 21 Nov 2017 23:42:00 +0000 (UTC) From: "Appy (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HBASE-19319) Fix bug in synchronizing over ProcedureEvent MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 21 Nov 2017 23:42:04 -0000 Appy created HBASE-19319: ---------------------------- Summary: Fix bug in synchronizing over ProcedureEvent Key: HBASE-19319 URL: https://issues.apache.org/jira/browse/HBASE-19319 Project: HBase Issue Type: Bug Reporter: Appy Assignee: Appy Following synchronizes over local variable rather than the original ProcedureEvent object. Clearly a bug since this code block won't follow exclusion with many of the synchronized methods in ProcedureEvent class. {code} @Override public void wakeEvents(final int count, final ProcedureEvent... events) { final boolean traceEnabled = LOG.isTraceEnabled(); schedLock(); try { int waitingCount = 0; for (int i = 0; i < count; ++i) { final ProcedureEvent event = events[i]; synchronized (event) { if (!event.isReady()) { {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)