Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 90CCA200D4C for ; Thu, 16 Nov 2017 04:41:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8F857160BF6; Thu, 16 Nov 2017 03:41:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D6B65160BF4 for ; Thu, 16 Nov 2017 04:41:03 +0100 (CET) Received: (qmail 31659 invoked by uid 500); 16 Nov 2017 03:41:02 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 31647 invoked by uid 99); 16 Nov 2017 03:41:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Nov 2017 03:41:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B03231A0F60 for ; Thu, 16 Nov 2017 03:41:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id u4HRSjZnDPrq for ; Thu, 16 Nov 2017 03:41:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BF89A5FAC5 for ; Thu, 16 Nov 2017 03:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 56E88E0D1F for ; Thu, 16 Nov 2017 03:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0ED6A240CE for ; Thu, 16 Nov 2017 03:41:00 +0000 (UTC) Date: Thu, 16 Nov 2017 03:41:00 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-19276) RegionPlan should correctly implement equals and hashCode MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 16 Nov 2017 03:41:04 -0000 [ https://issues.apache.org/jira/browse/HBASE-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254703#comment-16254703 ] Andrew Purtell commented on HBASE-19276: ---------------------------------------- The compareTo needs to stay the same I think, unless we implement the special comparison we need with a custom comparator. > RegionPlan should correctly implement equals and hashCode > --------------------------------------------------------- > > Key: HBASE-19276 > URL: https://issues.apache.org/jira/browse/HBASE-19276 > Project: HBase > Issue Type: Sub-task > Reporter: Andrew Purtell > Assignee: Andrew Purtell > Fix For: 1.4.0, 2.0.0-beta-1 > > Attachments: HBASE-19276-branch-1.patch, HBASE-19276.patch > > > error-prone identified dodgy code in AssignmentManager where we are relying on reference (object) equality to do the right thing, and are getting lucky, because if we properly used equals() the result is wrong, because RegionPlan does not correctly implement equals and hashCode according to the JDK contracts for same. -- This message was sent by Atlassian JIRA (v6.4.14#64029)