Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 13 Nov 2017 22:34:00 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13118079.1510610465000.225949.1510612440106@Atlassian.JIRA>
In-Reply-To: <JIRA.13118079.1510610465000@Atlassian.JIRA>
References: <JIRA.13118079.1510610465000@Atlassian.JIRA> <JIRA.13118079.1510610465837@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-19249) test for "hbase antipatterns"
 should check _count_ of occurance rather than text of
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 13 Nov 2017 22:34:04 -0000


    [ https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250384#comment-16250384 ] 

Hadoop QA commented on HBASE-19249:
-----------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  2m  7s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  4s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m  1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}  2m 33s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19249 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12897392/HBASE-19249.0.patch |
| Optional Tests |  asflicense  shellcheck  shelldocs  |
| uname | Linux dc2fea4929ef 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh |
| git revision | master / df82abb159 |
| maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| shellcheck | v0.4.4 |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/9776/console |
| Powered by | Apache Yetus 0.6.0   http://yetus.apache.org |


This message was automatically generated.


> test for "hbase antipatterns" should check _count_ of occurance rather than text of
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-19249
>                 URL: https://issues.apache.org/jira/browse/HBASE-19249
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Critical
>         Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed to flag a use.
> looking at our check:
> {code}
>   warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
>   if [[ ${warnings} -gt 0 ]]; then
>     add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase: ${warnings}."
>     ((result=result+1))
>   fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely giving a negative on all these checks.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)