Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id ED870200D43 for ; Tue, 21 Nov 2017 22:31:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EC008160BFC; Tue, 21 Nov 2017 21:31:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3F1B5160BE3 for ; Tue, 21 Nov 2017 22:31:04 +0100 (CET) Received: (qmail 35630 invoked by uid 500); 21 Nov 2017 21:31:03 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 35619 invoked by uid 99); 21 Nov 2017 21:31:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Nov 2017 21:31:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9FE79180724 for ; Tue, 21 Nov 2017 21:31:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id d9ifObeF2koh for ; Tue, 21 Nov 2017 21:31:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 288CC5FC6A for ; Tue, 21 Nov 2017 21:31:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 64A49E0051 for ; Tue, 21 Nov 2017 21:31:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 21CAD255A3 for ; Tue, 21 Nov 2017 21:31:00 +0000 (UTC) Date: Tue, 21 Nov 2017 21:31:00 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-19122) preCompact and preFlush can bypass by returning null scanner; shut it down MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 21 Nov 2017 21:31:05 -0000 [ https://issues.apache.org/jira/browse/HBASE-19122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261511#comment-16261511 ] stack commented on HBASE-19122: ------------------------------- .001 Changed preFlush and preCompact so if a CP returns null, we throw a CoprocessorException. Removed all fielding that catered to a null return. Added test to verify the CE comes out. > preCompact and preFlush can bypass by returning null scanner; shut it down > -------------------------------------------------------------------------- > > Key: HBASE-19122 > URL: https://issues.apache.org/jira/browse/HBASE-19122 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors, Scanners > Reporter: stack > Assignee: stack > Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19122.master.001.patch > > > Noticed by [~anoop.hbase] during review of HBASE-18770, preCompact and preFlush can bypass normal processing by returning null. They are not bypasable by ordained route. We should shut down this avenue. > The preCompact at least may be new coming in with: > {code} > tree dbf13093842f85a713f023d7219caccf8f4eb05f > parent a4dcf51415616772e462091ce93622f070ea8810 > author zhangduo Sat Apr 9 16:18:08 2016 +0800 > committer zhangduo Sun Apr 10 09:26:28 2016 +0800 > HBASE-15527 Refactor Compactor related classes > {code} > Would have to dig in more to figure for sure. -- This message was sent by Atlassian JIRA (v6.4.14#64029)