Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9177C200D45 for ; Thu, 9 Nov 2017 03:04:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8FDE7160BDA; Thu, 9 Nov 2017 02:04:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D65BE160C01 for ; Thu, 9 Nov 2017 03:04:04 +0100 (CET) Received: (qmail 40229 invoked by uid 500); 9 Nov 2017 02:04:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 40218 invoked by uid 99); 9 Nov 2017 02:04:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Nov 2017 02:04:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 382E8D35C2 for ; Thu, 9 Nov 2017 02:04:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id kqHJC5NYCpGc for ; Thu, 9 Nov 2017 02:04:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4679860F72 for ; Thu, 9 Nov 2017 02:04:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 89C3CE2572 for ; Thu, 9 Nov 2017 02:04:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id EFBC4240FE for ; Thu, 9 Nov 2017 02:04:00 +0000 (UTC) Date: Thu, 9 Nov 2017 02:04:00 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-18757) Fix Improper bitwise & in BucketCache offset calculation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 09 Nov 2017 02:04:05 -0000 [ https://issues.apache.org/jira/browse/HBASE-18757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-18757: ----------------------------------- Fix Version/s: (was: 1.5.0) > Fix Improper bitwise & in BucketCache offset calculation > -------------------------------------------------------- > > Key: HBASE-18757 > URL: https://issues.apache.org/jira/browse/HBASE-18757 > Project: HBase > Issue Type: Bug > Components: BucketCache > Reporter: Zach York > Assignee: Zach York > Fix For: 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-3 > > Attachments: HBASE-18757.branch-1.3.001.patch, HBASE-18757.master.001.patch, HBASE-18757.master.002.patch > > > Offset calculation for BucketCache entries incorrectly uses an int literal to try to ensure that the offset is positive. However, because it uses the string literal 0xFFFFFFFF which java uses at an int (which is negative). When it does the bitwise &, java sign extends the int effectively undoing the original intention of the code and allowing for negative values to slip through. > Then the read or write to that block will fail due to trying to read/write at a negative index which causes the BucketCache to fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029)