Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 1 Nov 2017 12:36:00 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13019905.1478802066000.120416.1509539760405@Atlassian.JIRA>
In-Reply-To: <JIRA.13019905.1478802066000@Atlassian.JIRA>
References: <JIRA.13019905.1478802066000@Atlassian.JIRA> <JIRA.13019905.1478802066274@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17065) Perform more effective sorting for
 RPC Handler Tasks
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 01 Nov 2017 12:36:05 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234017#comment-16234017 ] 

Ted Yu commented on HBASE-17065:
--------------------------------

lgtm


> Perform more effective sorting for RPC Handler Tasks
> ----------------------------------------------------
>
>                 Key: HBASE-17065
>                 URL: https://issues.apache.org/jira/browse/HBASE-17065
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Reid Chan
>            Priority: Minor
>              Labels: rpc, ui
>         Attachments: HBASE-17065.master.001.patch, Screen Shot 2017-11-01 at 5.38.53 PM.png, rpc-hdlr-tasks.png
>
>
> Under the 'Show All RPC Handler Tasks' tab, the tasks are not sorted according to the duration they have been in the current state (see picture).
> In TaskMonitorTmpl.jamon :
> {code}
> long now = System.currentTimeMillis();
> Collections.reverse(tasks);
> {code}
> The underlying tasks are backed by CircularFifoBuffer, leading to ineffective sorting.
> We should display tasks with the longest duration (in current state) first.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)