Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1F425200D4A for ; Tue, 28 Nov 2017 13:19:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 1DD6D160C07; Tue, 28 Nov 2017 12:19:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 61EB0160C01 for ; Tue, 28 Nov 2017 13:19:09 +0100 (CET) Received: (qmail 91407 invoked by uid 500); 28 Nov 2017 12:19:08 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 91394 invoked by uid 99); 28 Nov 2017 12:19:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Nov 2017 12:19:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 02DC8C0980 for ; Tue, 28 Nov 2017 12:19:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.011 X-Spam-Level: X-Spam-Status: No, score=-99.011 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KB_WAM_FROM_NAME_SINGLEWORD=0.2, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id wlsDG-1RXhAH for ; Tue, 28 Nov 2017 12:19:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4F8EB5F2C5 for ; Tue, 28 Nov 2017 12:19:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6A66CE25A2 for ; Tue, 28 Nov 2017 12:19:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 774C3241CB for ; Tue, 28 Nov 2017 12:19:01 +0000 (UTC) Date: Tue, 28 Nov 2017 12:19:01 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17049) Do not issue sync request when there are still entries in ringbuffer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 28 Nov 2017 12:19:10 -0000 [ https://issues.apache.org/jira/browse/HBASE-17049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268646#comment-16268646 ] ramkrishna.s.vasudevan commented on HBASE-17049: ------------------------------------------------ Tried with 24 threads as [~zghaobac] did and also 50 threads. Still it is 1 node DN and RS ( as I don have multi nodes readily available). And yes I can see improvement with this patch. One more change is that I performed this test on tip of branch-2. For previous results (that was based on 2.0-alpha4 refer here. https://issues.apache.org/jira/browse/HBASE-16890?focusedCommentId=16264057&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16264057 Now with both 24 and 50 threads I can see AsyncWAL performs better with this patch (with autoFlush= true). 50 threads FSHLog : Min: 683317ms Max: 692145ms Avg: 686008ms AsyncWAL : Min: 515266ms Max: 522350ms Avg: 517548ms 24 threads FSHLog : Min: 716638ms Max: 719082ms Avg: 718069ms ASyncWAL : Min: 552599ms Max: 554915ms Avg: 553826ms Results seems to be much better than the previous results now. Thanks [~Apache9]. Patch LGTM. > Do not issue sync request when there are still entries in ringbuffer > -------------------------------------------------------------------- > > Key: HBASE-17049 > URL: https://issues.apache.org/jira/browse/HBASE-17049 > Project: HBase > Issue Type: Sub-task > Components: wal > Reporter: Duo Zhang > Assignee: Duo Zhang > Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-17049.patch, delay-sync.patch > > > https://issues.apache.org/jira/browse/HBASE-16890?focusedCommentId=15647590&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15647590 -- This message was sent by Atlassian JIRA (v6.4.14#64029)