Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D3D12200D42 for ; Fri, 3 Nov 2017 03:37:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D2642160BFB; Fri, 3 Nov 2017 02:37:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 237F5160BE5 for ; Fri, 3 Nov 2017 03:37:05 +0100 (CET) Received: (qmail 34426 invoked by uid 500); 3 Nov 2017 02:37:05 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 34415 invoked by uid 99); 3 Nov 2017 02:37:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Nov 2017 02:37:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 91992DB5DB for ; Fri, 3 Nov 2017 02:37:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id S7BG7IMkkoLC for ; Fri, 3 Nov 2017 02:37:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 56E755FBEA for ; Fri, 3 Nov 2017 02:37:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8C732E0AA3 for ; Fri, 3 Nov 2017 02:37:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B3C6E23F05 for ; Fri, 3 Nov 2017 02:37:01 +0000 (UTC) Date: Fri, 3 Nov 2017 02:37:00 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-12125) Add Hbck option to check and fix WAL's from replication queue MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 03 Nov 2017 02:37:07 -0000 [ https://issues.apache.org/jira/browse/HBASE-12125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236993#comment-16236993 ] Ted Yu commented on HBASE-12125: -------------------------------- From the QA run: {code} [ERROR] testFixMissingReplicationWAL(org.apache.hadoop.hbase.util.TestHBaseFsckReplication) Time elapsed: 54.85 s <<< ERROR! java.lang.NullPointerException at org.apache.hadoop.hbase.util.TestHBaseFsckReplication.testFixMissingReplicationWAL(TestHBaseFsckReplication.java:184) {code} which was almost identical to the error I reported yesterday. > Add Hbck option to check and fix WAL's from replication queue > ------------------------------------------------------------- > > Key: HBASE-12125 > URL: https://issues.apache.org/jira/browse/HBASE-12125 > Project: HBase > Issue Type: Bug > Components: Replication > Affects Versions: 3.0.0 > Reporter: Virag Kothari > Assignee: Vincent Poon > Priority: Major > Attachments: HBASE-12125.v1.master.patch, HBASE-12125.v2.master.patch, HBASE-12125.v3.master.patch > > > The replication source will discard the WAL file in many cases when it encounters an exception reading it . This can cause data loss > and the underlying reason of failed read remains hidden. Only in certain scenarios, the replication source should dump the current WAL and move to the next one. > This JIRA aims to have an hbck option to check the WAL files of replication queues for any inconsistencies and also provide an option to fix it. > The fix can be to remove the file from replication queue in zk and from the memory of replication source manager and replication sources. > A region server endpoint call from the hbck client to region server can be used to achieve this. > Hbck can be configured with the following options: > -softCheckReplicationWAL : Tries to open only the oldest WAL (the WAL currently read by replication source) from replication queue. If there is a position associated, it also seeks to that position and reads an entry from there > -hardCheckReplicationWAL: Check all WAL paths from replication queues by reading them completely to make sure they are ok. > -fixMissingReplicationWAL: Remove the WAL's from replication queues which are not present on hdfs > -fixCorruptedReplicationWAL: Remove the WAL's from replication queues which are corrupted (based on the findings from softCheck/hardCheck). Also the WAL's are moved to a quarantine dir > -rollAndFixCorruptedReplicationWAL - If the current WAL is corrupted, it is first rolled over and then deals with it in the same way as -fixCorruptedReplicationWAL option -- This message was sent by Atlassian JIRA (v6.4.14#64029)