hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19338) Performance regression in RegionServerRpcQuotaManager to get ugi
Date Fri, 24 Nov 2017 00:44:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264850#comment-16264850
] 

Duo Zhang commented on HBASE-19338:
-----------------------------------

{quote}
Yes, User.getCurrent throws IOException, looks like we can not use orElseGet here.
{quote}

OK, that must be why I do not use User::getCurrent at the first place.

Nice finding. Maybe we could introduce a helper method to avoid writing the if condition in
multiple places. But this is not a critical problem, can do it later, or just ignore it is
also fine.

+1 on the patch. 

Thanks.

> Performance regression in RegionServerRpcQuotaManager to get ugi 
> -----------------------------------------------------------------
>
>                 Key: HBASE-19338
>                 URL: https://issues.apache.org/jira/browse/HBASE-19338
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 3.0.0, 2.0.0-beta-2
>            Reporter: binlijin
>            Assignee: binlijin
>            Priority: Critical
>         Attachments: 19338.master.003.patch, HBASE-19338.master.001.patch, HBASE-19338.master.002.patch
>
>
> we find hbase-2.0.0-beta-1.SNAPSHOT have performance regression with yscb put  and have
some finding.  
> {code}
> "RpcServer.default.FPBQ.Fifo.handler=131,queue=17,port=16020" #245 daemon prio=5 os_prio=0
tid=0x00007fc82b22e000 nid=0x3a5db waiting for monitor entry [0x00007fc50fafa000]
>    java.lang.Thread.State: BLOCKED (on object monitor)
>         at org.apache.hadoop.security.UserGroupInformation.getCurrentUser(UserGroupInformation.java:647)
>         - waiting to lock <0x00007fcaedc20830> (a java.lang.Class for org.apache.hadoop.security.UserGroupInformation)
>         at org.apache.hadoop.hbase.security.User$SecureHadoopUser.<init>(User.java:264)
>         at org.apache.hadoop.hbase.security.User.getCurrent(User.java:162)
>         at org.apache.hadoop.hbase.quotas.RegionServerRpcQuotaManager.checkQuota(RegionServerRpcQuotaManager.java:179)
>         at org.apache.hadoop.hbase.quotas.RegionServerRpcQuotaManager.checkQuota(RegionServerRpcQuotaManager.java:162)
>         at org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2521)
>         at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41560)
>         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
>         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
>         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
>         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message