hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19333) Consider exposing ExportSnapshot#getSnapshotFiles through POJO class
Date Wed, 22 Nov 2017 23:24:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263543#comment-16263543
] 

Ted Yu commented on HBASE-19333:
--------------------------------

bq. And whats with the 'Consider'? Why file issue an issue for a 'Consideration'?

I am confused. There have been precedents. e.g.

HBASE-15762 Consider hbase-client to be shaded by default in 2.0

> Consider exposing ExportSnapshot#getSnapshotFiles through POJO class
> --------------------------------------------------------------------
>
>                 Key: HBASE-19333
>                 URL: https://issues.apache.org/jira/browse/HBASE-19333
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>
> In the thread, http://search-hadoop.com/m/HBase/YGbbUxY9FyU74X?subj=Re+Deleting+and+cleaning+old+snapshots+exported+to+S3
, Timothy mentioned that he used reflection to get to ExportSnapshot#getSnapshotFiles().
> {code}
>   private static List<Pair<SnapshotFileInfo, Long>> getSnapshotFiles(final
Configuration conf,
>       final FileSystem fs, final Path snapshotDir) throws IOException {
> {code}
> SnapshotFileInfo is protobuf.
> We should consider exposing the API by replacing the protobuf class with POJO class.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message