hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19328) Remove asked if splittable log messages
Date Wed, 22 Nov 2017 16:06:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262839#comment-16262839
] 

stack commented on HBASE-19328:
-------------------------------

That is pure debug that should not have made it into code base. Thanks for surfacing it [~balazs.meszaros]

Both of these lines can go:

    LOG.info("ASKED IF SPLITTABLE " + result + " " + getRegionInfo().getShortNameToLog(),
      new Throwable("LOGGING: REMOVE"));
    // REMOVE BELOW!!!!
    LOG.info("DEBUG LIST ALL FILES");



> Remove asked if splittable log messages
> ---------------------------------------
>
>                 Key: HBASE-19328
>                 URL: https://issues.apache.org/jira/browse/HBASE-19328
>             Project: HBase
>          Issue Type: Task
>          Components: proc-v2
>    Affects Versions: 3.0.0
>            Reporter: Balazs Meszaros
>            Priority: Minor
>
> I have found this log message in HBase log:
> {code}
> 2017-11-22 11:16:54,133 INFO  [RpcServer.priority.FPBQ.Fifo.handler=5,queue=0,port=52586]
regionserver.HRegion(1309): ASKED IF SPLITTABLE true 0a66d6e20801eec2c6cd1204fedde592
> java.lang.Throwable: LOGGING: REMOVE
> 	at org.apache.hadoop.hbase.regionserver.HRegion.isSplittable(HRegion.java:1310)
> 	at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegionInfo(RSRpcServices.java:1665)
> 	at org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:28159)
> 	at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
> 	at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
> 	at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:325)
> 	at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:305)
> {code}
> Still we need this?
> It was introduced in commit {{dc1065a85}} by [~stack] and [~mbertozzi].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message