hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19298) CellScanner should be declared as IA.Public
Date Tue, 21 Nov 2017 09:33:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260467#comment-16260467
] 

Chia-Ping Tsai commented on HBASE-19298:
----------------------------------------

bq. On the patch, whats up w/ the ExtendedCellScanner. Why we need it?
The interface used in server side should differ from the interface exposed publicly. Otherwise,
the tragedy, which is like HBASE-19092, will strike again in the future. It is unrelated to
this issue, at any rate. I will submit a patch which just makes {{CellScanner}} and {{CellScannable}}
public. Thanks for the feedback. [~stack] 

> CellScanner should be declared as IA.Public
> -------------------------------------------
>
>                 Key: HBASE-19298
>                 URL: https://issues.apache.org/jira/browse/HBASE-19298
>             Project: HBase
>          Issue Type: Task
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19298.v0.patch
>
>
> User can create the {{CellScanner}} via IA.Public {{CellUtil}}, hence {{CellScanner}}
should be IA.Public. However, the {{CellScanner}} is used in the server code base so making
{{CellScanner}} IA.Public may flaw our HBASE in the future. In my opinion, we should introduce
the {{ExtendedCellScanner}} to replace the {{CellScanner}} for server code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message