hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-19291) Use common header and footer for JSP pages
Date Mon, 20 Nov 2017 21:24:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259869#comment-16259869
] 

Appy edited comment on HBASE-19291 at 11/20/17 9:23 PM:
--------------------------------------------------------

[~Apache9] I accessed all the pages on a standalone cluster and they looked alright.
Thanks for the review [~elserj]. I am absolutely comfortable since i tried it like 2-3 times.
:)
But let me wait for reply from Duo before committing. 


was (Author: appy):
[~Apache9] I accessed all the pages on a standalone cluster and they looked alright.
Thanks for the review [~elserj].
Let me wait for reply from Duo before committing. 

> Use common header and footer for JSP pages
> ------------------------------------------
>
>                 Key: HBASE-19291
>                 URL: https://issues.apache.org/jira/browse/HBASE-19291
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>         Attachments: HBASE-19291.master.001.patch
>
>
> Use header and footer in our *.jsp pages to avoid unnecessary redundancy (copy-paste
of code)
> (Been sitting in my local repo for long, best to get following pesky user-facing things
fixed before the next major release)
> Misc edits:
> - Due to redundancy, new additions make it to some places but not others. For eg there
are missing links to "/logLevel", "/processRS.jsp" in few places.
> - Fix processMaster.jsp wrongly pointing to rs-status instead of master-status (probably
due to copy paste from processRS.jsp)
> - Deleted a bunch of extraneous "</a>" in processMaster.jsp & processRS.jsp
> - Added missing </div> tag in snapshot.jsp
> - Deleted fossils of html5shiv.js. It's uses and the js itself were deleted in the commit
"819aed4ccd073d818bfef5931ec8d248bfae5f1f"
> - Fixed wrongly matched heading tags
> - Deleted some unused variables
> Tested:
> Ran standalone cluster and opened each page to make sure it looked right.
> Sidenote:
> Looks like HBASE-3835 started the work of converting from jsp to jamon, but the work
didn't finish. Now we have a mix of jsp and jamon. Needs reconciling, but later.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message