hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19276) RegionPlan should correctly implement equals and hashCode
Date Thu, 16 Nov 2017 07:26:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254864#comment-16254864

stack commented on HBASE-19276:

.001 Revamps compareTo.

Feel free to by-pass my experient [~apurtell] and commit your patch. Just trying this overnight
to see who might be relying on dodgy compareTo in RegionPlan.

> RegionPlan should correctly implement equals and hashCode
> ---------------------------------------------------------
>                 Key: HBASE-19276
>                 URL: https://issues.apache.org/jira/browse/HBASE-19276
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 1.4.0, 2.0.0-beta-1
>         Attachments: HBASE-19276-branch-1.patch, HBASE-19276.master.001.patch, HBASE-19276.patch
> error-prone identified dodgy code in AssignmentManager where we are relying on reference
(object) equality to do the right thing, and are getting lucky, because if we properly used
equals() the result is wrong, because RegionPlan does not correctly implement equals and hashCode
according to the JDK contracts for same. 

This message was sent by Atlassian JIRA

View raw message