hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19276) RegionPlan should correctly implement equals and hashCode
Date Thu, 16 Nov 2017 03:18:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254686#comment-16254686

Chia-Ping Tsai commented on HBASE-19276:

The {{equal}} looks good to me. Should we also rewrite the {{compareTo}}? The patch cause
the evaluation of {{equal}} result differ from {{compareTo() == 0}}.

> RegionPlan should correctly implement equals and hashCode
> ---------------------------------------------------------
>                 Key: HBASE-19276
>                 URL: https://issues.apache.org/jira/browse/HBASE-19276
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 1.4.0, 2.0.0-beta-1
>         Attachments: HBASE-19276-branch-1.patch, HBASE-19276.patch
> error-prone identified dodgy code in AssignmentManager where we are relying on reference
(object) equality to do the right thing, and are getting lucky, because if we properly used
equals() the result is wrong, because RegionPlan does not correctly implement equals and hashCode
according to the JDK contracts for same. 

This message was sent by Atlassian JIRA

View raw message