hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19262) Revisit checkstyle rules
Date Thu, 16 Nov 2017 01:47:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254620#comment-16254620
] 

Hudson commented on HBASE-19262:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-1.4 #1020 (See [https://builds.apache.org/job/HBase-1.4/1020/])
HBASE-19262 Revisit checkstyle rules (zhangduo: rev 2200397fc3f9ff5da04c97269bec5b548d3485a6)
* (edit) hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml
* (edit) hbase-checkstyle/src/main/resources/hbase/checkstyle.xml


> Revisit checkstyle rules
> ------------------------
>
>                 Key: HBASE-19262
>                 URL: https://issues.apache.org/jira/browse/HBASE-19262
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>         Attachments: HBASE-19262.patch, idea_import_layout.png
>
>
> For the shaded imports, I prefer we put it at the bottom with a separated block. And
also, for UTs which use junit rule, we usually declare the field as public but checkstyle
will report a VisibilityModifier problem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message