hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Reid Chan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19262) Revisit checkstyle rules
Date Wed, 15 Nov 2017 07:25:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253052#comment-16253052
] 

Reid Chan commented on HBASE-19262:
-----------------------------------

bq. For the shaded imports, I prefer we put it at the bottom with a separated block.
Agree. Old version of check-style is as your description, code base is mixed with two styles
now.

> Revisit checkstyle rules
> ------------------------
>
>                 Key: HBASE-19262
>                 URL: https://issues.apache.org/jira/browse/HBASE-19262
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>            Reporter: Duo Zhang
>
> For the shaded imports, I prefer we put it at the bottom with a separated block. And
also, for UTs which use junit rule, we usually declare the field as public but checkstyle
will report a VisibilityModifier problem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message