hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19239) Fix findbugs and error-prone warnings
Date Thu, 16 Nov 2017 22:28:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256065#comment-16256065

Mike Drob commented on HBASE-19239:

[~apurtell] - I started reviewing here and not on RB, so I'm going to finish the comment if
you don't mind.

In InvalidFamilyOperationException.java (and others) we're setting the serialVersionId, I
think we did want to do the shift first then subtract, not subtract then shift.

In lots of places, I've heard that using StandardCharsets.UTF_8 is 15% slower than the string
charset name equivalent for getBytes(). I hope this isn't true anymore, actually.

In TestAsyncProcess.java I would prefer Collections.singletonList instead of using google
Lists class.

TestProcedureInMemoryChore.java: boolean result is unused?
Same for TestClientPushback.java
Looks like there's more of these that I'm not going to explicitly list unless you need me

RpcServer.java: why not start = rand.nextInt(numConnections)?
similar for TestFastFail.java

TestStripeStoreFileManager.java: good spot for assertArrayEquals

> Fix findbugs and error-prone warnings
> -------------------------------------
>                 Key: HBASE-19239
>                 URL: https://issues.apache.org/jira/browse/HBASE-19239
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 3.0.0, 1.4.0, 2.0.0-beta-1
>         Attachments: HBASE-19239-branch-1.patch
> Fix important findbugs and error-prone warnings on branch-1.4 / branch-1. Forward port
as appropriate. 

This message was sent by Atlassian JIRA

View raw message