hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19238) Port Hadoop's new GcTimeMonitor
Date Wed, 29 Nov 2017 21:20:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271554#comment-16271554

stack commented on HBASE-19238:

Patch looks good (Stop would be good though it looks like monitorThread is daemon).

Do we need this?

The GarbageCollectorMXBean bean is already available w/ more detail than is exploited here.
Its content shows in the metrics dump:

name: "java.lang:type=GarbageCollector,name=ParNew",
modelerType: "sun.management.GarbageCollectorImpl",

This is also YetAnotherThread which is doing nothing but sit around most of its lifetime w/
occasional super basic math problem.

Meh on giving out alerts though I suppose it would be nice to show in Interface. I'd think
that operators would have alert on JVM strugglng already?

> Port Hadoop's new GcTimeMonitor
> -------------------------------
>                 Key: HBASE-19238
>                 URL: https://issues.apache.org/jira/browse/HBASE-19238
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Trivial
>             Fix For: 1.4.0, 2.0.0-beta-1
>         Attachments: HBASE-19238-branch-1.patch, HBASE-19238.patch
> We borrowed Hadoop's JvmPauseMonitor some time ago. On HADOOP-14960 (Add GC time percentage
monitor/alerter), Hadoop added a new GcTimeMonitor, which seems useful:
> {code}
> /**
>  * This class monitors the percentage of time the JVM is paused in GC within
>  * the specified observation window, say 1 minute. The user can provide a
>  * hook which will be called whenever this percentage exceeds the specified
>  * threshold.
>  */
> {code}

This message was sent by Atlassian JIRA

View raw message