hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs
Date Mon, 13 Nov 2017 23:08:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250429#comment-16250429
] 

Appy edited comment on HBASE-19235 at 11/13/17 11:07 PM:
---------------------------------------------------------

Oh, i said "let's clean this up" earlier but forgot to make an alternative suggestion:
If this is the only case of  child interface public but parent private, am all in for the
solution discussed above - Make CpEnv public and let's move internal functions to BaseEnvironment
or mark them private.

But if we have this in multiple places (you aware of more [~anoop.hbase]?), let's try to find
a global solution first? We can either:
1) Make all parent's public 
2) Explicitly say in our docs how these labels are to be interpreted w.r.t. inheritance.
(Any other way am missing?)
I think both of the above solutions will tackle the overall problem, but one makes more sense
than other (at least to me ..smile) since there will be parent interfaces we just can't make
public.


was (Author: appy):
Oh, i said "let's clean this up" earlier but forgot to make an alternative suggestion:
If we have this in multiple places i.e. child public but parent private, let's try to find
a global solution first? We can either:
1) Make all parent's public 
2) Explicitly say in our docs how these labels are to be interpreted w.r.t. inheritance.
(Any other way am missing?)
I think both of the above solutions will tackle the overall problem, but one makes more sense
than other (at least to me ..smile) since there will be parent interfaces we just can't make
public.

> CoprocessorEnvironment should be exposed to CPs
> -----------------------------------------------
>
>                 Key: HBASE-19235
>                 URL: https://issues.apache.org/jira/browse/HBASE-19235
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>    Affects Versions: 2.0.0-alpha-4
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Minor
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19235.patch, HBASE-19235_V2.patch
>
>
> Its sub interfaces are exposed with LimitedPrivate(HBaseInterfaceAudience.COPROC).  So
ideally all the functions in this are.  Better we mark CoprocessorEnvironment also as CP exposed
to avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message