hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs
Date Fri, 10 Nov 2017 09:56:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247278#comment-16247278
] 

Anoop Sam John commented on HBASE-19235:
----------------------------------------

I see now..  The startup and shutdown were there in Environment only(Now BaseEnv)  . All 4
types of  CPEnv impls are sub types of BaseEnv.  Previously we were doing type casting and
call these 2 methods.
{code}
if (env instanceof Environment) {
      ((Environment)env).startup();
    }
if (e instanceof Environment) {
      if (LOG.isDebugEnabled()) {
        LOG.debug("Stop coprocessor " + e.getInstance().getClass().getName());
      }
      ((Environment)e).shutdown();
    }
{code}
I think we can continue this way. Its ok and so avoid these 2 APIs being exposed to CPs

> CoprocessorEnvironment should be exposed to CPs
> -----------------------------------------------
>
>                 Key: HBASE-19235
>                 URL: https://issues.apache.org/jira/browse/HBASE-19235
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>    Affects Versions: 2.0.0-alpha-4
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Minor
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19235.patch
>
>
> Its sub interfaces are exposed with LimitedPrivate(HBaseInterfaceAudience.COPROC).  So
ideally all the functions in this are.  Better we mark CoprocessorEnvironment also as CP exposed
to avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message