hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19194) TestRSGroupsBase has some always false checks
Date Wed, 08 Nov 2017 01:16:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243217#comment-16243217
] 

Hadoop QA commented on HBASE-19194:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 19m 35s{color} | {color:blue}
Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  0s{color}
| {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 1 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m  9s{color} | {color:red}
root in master failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 28s{color} |
{color:green} master passed with JDK v1.8.0_141 {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m  9s{color} | {color:red}
hbase-rsgroup in master failed with JDK v1.7.0_151. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 13s{color}
| {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red}  0m 20s{color} | {color:red}
branch has 7 errors when building our shaded downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m  9s{color} | {color:red}
hbase-rsgroup in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 14s{color} |
{color:green} master passed with JDK v1.8.0_141 {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m  8s{color} | {color:red}
hbase-rsgroup in master failed with JDK v1.7.0_151. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m  7s{color} | {color:red}
root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 15s{color} |
{color:green} the patch passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 15s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m  9s{color} | {color:red}
hbase-rsgroup in the patch failed with JDK v1.7.0_151. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m  9s{color} | {color:red}
hbase-rsgroup in the patch failed with JDK v1.7.0_151. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 12s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red}  0m  7s{color} | {color:red}
patch has 7 errors when building our shaded downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  0m 14s{color} | {color:red}
The patch causes 7 errors with Hadoop v2.6.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  0m 22s{color} | {color:red}
The patch causes 7 errors with Hadoop v2.6.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  0m 28s{color} | {color:red}
The patch causes 7 errors with Hadoop v2.6.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  0m 35s{color} | {color:red}
The patch causes 7 errors with Hadoop v2.6.4. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  0m 42s{color} | {color:red}
The patch causes 7 errors with Hadoop v2.6.5. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  0m 50s{color} | {color:red}
The patch causes 7 errors with Hadoop v2.7.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  0m 57s{color} | {color:red}
The patch causes 7 errors with Hadoop v2.7.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  1m  4s{color} | {color:red}
The patch causes 7 errors with Hadoop v2.7.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  1m 10s{color} | {color:red}
The patch causes 7 errors with Hadoop v2.7.4. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  1m 18s{color} | {color:red}
The patch causes 7 errors with Hadoop v3.0.0-alpha4. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m  9s{color} | {color:red}
hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 16s{color} |
{color:green} the patch passed with JDK v1.8.0_141 {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m  9s{color} | {color:red}
hbase-rsgroup in the patch failed with JDK v1.7.0_151. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 10s{color} | {color:red}
hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m  7s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 20s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:4bf71c3 |
| JIRA Issue | HBASE-19194 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12896552/HBASE-19194.patch
|
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti
 checkstyle  compile  |
| uname | Linux 15cdcb0737a6 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 46408e0 |
| maven | version: Apache Maven 3.0.5 |
| Default Java | 1.7.0_151 |
| Multi-JDK versions |  /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_141 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_151
|
| mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/9676/artifact/patchprocess/branch-mvninstall-root.txt
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/9676/artifact/patchprocess/branch-compile-hbase-rsgroup-jdk1.7.0_151.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/9676/artifact/patchprocess/branch-findbugs-hbase-rsgroup.txt
|
| javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/9676/artifact/patchprocess/branch-javadoc-hbase-rsgroup-jdk1.7.0_151.txt
|
| mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/9676/artifact/patchprocess/patch-mvninstall-root.txt
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/9676/artifact/patchprocess/patch-compile-hbase-rsgroup-jdk1.7.0_151.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/9676/artifact/patchprocess/patch-compile-hbase-rsgroup-jdk1.7.0_151.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/9676/artifact/patchprocess/patch-findbugs-hbase-rsgroup.txt
|
| javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/9676/artifact/patchprocess/patch-javadoc-hbase-rsgroup-jdk1.7.0_151.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/9676/artifact/patchprocess/patch-unit-hbase-rsgroup.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/9676/testReport/ |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/9676/console |
| Powered by | Apache Yetus 0.6.0   http://yetus.apache.org |


This message was automatically generated.



> TestRSGroupsBase has some always false checks
> ---------------------------------------------
>
>                 Key: HBASE-19194
>                 URL: https://issues.apache.org/jira/browse/HBASE-19194
>             Project: HBase
>          Issue Type: Bug
>          Components: rsgroup, test
>            Reporter: Mike Drob
>            Assignee: Andrew Purtell
>            Priority: Blocker
>             Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
>         Attachments: HBASE-19194-branch-1.patch, HBASE-19194.patch
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
(default-testCompile) on project hbase-rsgroup: Compilation failure: Compilation failure:
> [ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
[CollectionIncompatibleType] Argument 'region' should not be passed to this method; its type
RegionInfo is not compatible with its collection's type argument String
> [ERROR]     (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
[CollectionIncompatibleType] Argument 'targetRegion' should not be passed to this method;
its type String is not compatible with its collection's type argument RegionInfo
> [ERROR]     (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List<T>.contains}} with an element of the wrong type
so they will always return false. The first is an optimization that we can probably live without
(or short circuit on the Master, at least) the second is an assertion that will never fail,
rendering the test ineffective.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message