hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19194) TestRSGroupsBase has some always false checks
Date Wed, 08 Nov 2017 00:45:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243181#comment-16243181
] 

Andrew Purtell commented on HBASE-19194:
----------------------------------------

This is a really important find. Thanks [~mdrob] for keeping up error-prone and filing an
issue for this problem. 

In HBASE-15631 we dropped a hunk from HMaster in review because it was a core change that
didn't have any coverage in the RSGroups tests. A test which should have failed passed because
it was silently broken in the way error-prone identified. Attaching a patch with the test
fixes and the inclusion of that dropped hunk as fix for the now correctly failing test. 

> TestRSGroupsBase has some always false checks
> ---------------------------------------------
>
>                 Key: HBASE-19194
>                 URL: https://issues.apache.org/jira/browse/HBASE-19194
>             Project: HBase
>          Issue Type: Bug
>          Components: rsgroup, test
>            Reporter: Mike Drob
>            Assignee: Andrew Purtell
>            Priority: Minor
>             Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1
>
>
> Discovered via error-prone analysis:
> {noformat}
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:testCompile
(default-testCompile) on project hbase-rsgroup: Compilation failure: Compilation failure:
> [ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[421,40]
[CollectionIncompatibleType] Argument 'region' should not be passed to this method; its type
RegionInfo is not compatible with its collection's type argument String
> [ERROR]     (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> [ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java:[531,65]
[CollectionIncompatibleType] Argument 'targetRegion' should not be passed to this method;
its type String is not compatible with its collection's type argument RegionInfo
> [ERROR]     (see http://errorprone.info/bugpattern/CollectionIncompatibleType)
> {noformat}
> Both of these are checks to {{List<T>.contains}} with an element of the wrong type
so they will always return false. The first is an optimization that we can probably live without
(or short circuit on the Master, at least) the second is an assertion that will never fail,
rendering the test ineffective.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message