hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Reid Chan (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-19141) [compat 1-2] getClusterStatus always return empty ClusterStatus
Date Thu, 02 Nov 2017 03:59:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235135#comment-16235135
] 

Reid Chan edited comment on HBASE-19141 at 11/2/17 3:58 AM:
------------------------------------------------------------

 I recommend to add following codes 
{code}
    // given that hbase1 can't submit the request with Option,
    // we return all information to client if the list of Option is empty.
    if (options.isEmpty()) {
       options = EnumSet.allOf(Option.class);
    }
{code}
in method {{EnumSet<Option> toOptions(List<ClusterStatusProtos.Option> options)}}
in {{ProtobufUtil}}, instead of in {{HMaster}}
{code}
public static EnumSet<Option> toOptions(List<ClusterStatusProtos.Option> options)
{
    // given that hbase1 can't submit the request with Option,
    // we return all information to client if the list of Option is empty.
    if (options.isEmpty()) {
       return EnumSet.allOf(Option.class);
    }
    ...
}
{code}
though it is committed. : p


was (Author: reidchan):
 I recommend to add following codes 
{code}
    // given that hbase1 can't submit the request with Option,
    // we return all information to client if the list of Option is empty.
    if (options.isEmpty()) {
       options = EnumSet.allOf(Option.class);
    }
{code}
in method {{EnumSet<Option> toOptions(List<ClusterStatusProtos.Option> options)}}
in {{ProtobufUtil}}, 
{code}
public static EnumSet<Option> toOptions(List<ClusterStatusProtos.Option> options)
{
    // given that hbase1 can't submit the request with Option,
    // we return all information to client if the list of Option is empty.
    if (options.isEmpty()) {
       return EnumSet.allOf(Option.class);
    }
    ...
}
{code}
though it is committed. : p

>  [compat 1-2] getClusterStatus always return empty ClusterStatus
> ----------------------------------------------------------------
>
>                 Key: HBASE-19141
>                 URL: https://issues.apache.org/jira/browse/HBASE-19141
>             Project: HBase
>          Issue Type: Sub-task
>          Components: API
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Critical
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19141.v0.patch, HBASE-19141.v1.patch
>
>
> We are able to limit the scope to get part of {{ClusterStatus}} in 2.0. However the request
sent by 1.x client has no specific scope info to retrieve any information from {{ClusterStatus}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message