hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-19128) Purge Distributed Log Replay from codebase, configurations, text; mark the feature as unsupported, broken.
Date Tue, 07 Nov 2017 03:43:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240845#comment-16240845
] 

Appy edited comment on HBASE-19128 at 11/7/17 3:42 AM:
-------------------------------------------------------

I tend to note down things which are important or worth highlighting or out of obvious when
dealing with new stuff, so anyone following the work and familiar with these code parts can
quickly validate the work. Here's the list (i'll keep updating it as we go):
- RecoveringRegionWatcher: We create it's instance in HRegionServer, but never use it.
- I see "hbase.master.distributed.log.replay" in https://github.com/apache/hbase/blob/master/src/main/asciidoc/_chapters/hbase-default.adoc,
 but not in [hbase book's default configs|http://hbase.apache.org/book.html#config.files].
Why?
- We were advertising in one places that DLR is On by default - [hbase-default ascii doc|https://github.com/apache/hbase/blob/master/src/main/asciidoc/_chapters/hbase-default.adoc]
- The configuration "hbase.master.distributed.log.replay" is never used in non-test code!
Which I think is both good and bad.
Good --> No one can be using DLR right now (even if they set the config to true), so no
upgrade issues. Bad --> It's simply weird!
- Although RSRpcServices#replay was added as part of DLR, it's now also used by RegionReplicas.
So can't delete that.
{noformat}
  @QosPriority(priority = HConstants.REPLAY_QOS)
  public ReplicateWALEntryResponse replay(final RpcController controller,
      final ReplicateWALEntryRequest request) throws ServiceException {
{noformat}



Removal is combination of HBASE-7006 and HBASE-13121 ([~enis])


was (Author: appy):
I tend to note down things which are important or worth highlighting or out of obvious when
dealing with new stuff, so anyone following the work and familiar with these code parts can
quickly validate the work. Here's the list (i'll keep updating it as we go):
- RecoveringRegionWatcher: We create it's instance in HRegionServer, but never use it.
- I see "hbase.master.distributed.log.replay" in https://github.com/apache/hbase/blob/master/src/main/asciidoc/_chapters/hbase-default.adoc,
 but not in [hbase book's default configs|http://hbase.apache.org/book.html#config.files].
Why?
- We were advertising in one places that DLR is On by default - [hbase-default ascii doc|https://github.com/apache/hbase/blob/master/src/main/asciidoc/_chapters/hbase-default.adoc]
- The configuration "hbase.master.distributed.log.replay" is never used in non-test code!
Which I think is both good and bad.
Good --> No one can be using DLR right now (even if they set the config to true), so no
upgrade issues. Bad --> It's simply weird!



Removal is combination of HBASE-7006 and HBASE-13121 ([~enis])

> Purge Distributed Log Replay from codebase, configurations, text; mark the feature as
unsupported, broken.
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-19128
>                 URL: https://issues.apache.org/jira/browse/HBASE-19128
>             Project: HBase
>          Issue Type: Sub-task
>          Components: documentation
>            Reporter: stack
>            Assignee: Appy
>              Labels: incompatible
>             Fix For: 2.0.0
>
>         Attachments: HBASE-19128.master.001.patch, HBASE-19128.master.002.patch
>
>
> Kill it. It keeps coming up and over again. Needs proper burial.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message