hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Liang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19127) Set State.SPLITTING, MERGING, MERGING_NEW, SPLITTING_NEW properly in RegionStatesNode
Date Tue, 07 Nov 2017 21:40:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242946#comment-16242946
] 

Yi Liang commented on HBASE-19127:
----------------------------------

[~stack]
{quote}What does the change in AM do? (Adding state for daughters)?{quote}
Yes, this is to add state for daughters

{quote}Don't change numbering in protobufs.{quote}
The reason why I remove MERGE_TABLE_REGIONS_MOVE_REGION_TO_SAME_RS = 3 in proto, because it
has never been used in the current code. Do you think this will cause some compatibility issues?
If you think it is better to keep them, I will keep it. Otherwise, I think it is safe to remove
them, since MergeTableRegionsProcedure is newly added since hbase-2.0.





> Set State.SPLITTING, MERGING, MERGING_NEW, SPLITTING_NEW properly in RegionStatesNode
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-19127
>                 URL: https://issues.apache.org/jira/browse/HBASE-19127
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Yi Liang
>            Assignee: Yi Liang
>         Attachments: state.patch
>
>
> In current code, we did not set above states to a region node at all, but we still have
statements like below to check if node have above states.
> {code}
> else if (!regionNode.isInState(State.CLOSING, State.SPLITTING)) {
> ....
> }
> {code}
> We need to set above states in a correct place.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message