hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-19112) Suspect methods on Cell to be deprecated
Date Tue, 21 Nov 2017 21:55:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261545#comment-16261545
] 

stack edited comment on HBASE-19112 at 11/21/17 9:54 PM:
---------------------------------------------------------

bq. The type of cells for normal scan (i.e non-raw scan) is always PUT type.

This is obvious now you state it but yeah, good one. It is an argument for deprecating getType
in Cell. (I see where you are coming from [~chia7712] now with RawScan returning RawCells).

You make a good argument [~chia7712] of a Type per Audience type.

Its too late to add in a RawCell? Don't you think? Over in HBASE-19092, if a CP wants access
to Tags, suggestion is cast to ExtendedCell. What you think [~chia7712]?

That means in this issue we deprecate

 # getTypeByte (Already deprecated in favor of CellUtil#isDelete, etc.)
 # getSequenceId
 # getTagsXXX




was (Author: stack):
bq. The type of cells for normal scan (i.e non-raw scan) is always PUT type.

This is obvious now you state it but yeah, good one. It is an argument for deprecating getType
in Cell. (I see where you are coming from [~chia7712] now with RawScan returning RawCells).

You make a good argument [~chia7712] of a Type per Audience type.

Its too late to add in a RawCell? Don't you think? Over in HBASE-19092, if a CP wants access
to Tags, suggestion is cast to ExtendedCell. What you think [~chia7712]?

That means in this issue we deprecate

 # getTypeByte (Already deprecated in favor of CellUtil#isDelete)
 # getSequenceId
 # getTagsXXX



> Suspect methods on Cell to be deprecated
> ----------------------------------------
>
>                 Key: HBASE-19112
>                 URL: https://issues.apache.org/jira/browse/HBASE-19112
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: Josh Elser
>            Priority: Blocker
>             Fix For: 2.0.0-beta-1
>
>
> [~chia7712] suggested on the [mailing list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there aren't others
which are either implementation details or methods returning now-private-marked classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message