hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19112) Suspect methods on Cell to be deprecated
Date Thu, 16 Nov 2017 23:36:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256161#comment-16256161
] 

stack commented on HBASE-19112:
-------------------------------

Lets get this done if we are going to do it.

On the original list of problematic methods:

 * What we propose instead of getType? What would user use instead?
 * Why not let out timestamp? Because it could be HLC timestamp?
 * There is no getTag in Cell. There is getTagsArray and getTagsOffset. We talking about deprecating
these?
 * We want to hide sequencid? It is used-client side scanning. We'd just keep it hidden?

We just made it so a CP can build their own Cell via an exposed ExtendedCellBuilder.

I have trouble with RawCell AND ExtendedCell. I like RawCell as a type. Can we rename ExtendedCell
as RawCell?I like saying that CPs can't modify a Cell that HBase has made.

> Suspect methods on Cell to be deprecated
> ----------------------------------------
>
>                 Key: HBASE-19112
>                 URL: https://issues.apache.org/jira/browse/HBASE-19112
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: Josh Elser
>            Priority: Blocker
>             Fix For: 2.0.0-beta-1
>
>
> [~chia7712] suggested on the [mailing list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there aren't others
which are either implementation details or methods returning now-private-marked classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message