hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs
Date Wed, 22 Nov 2017 08:03:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262117#comment-16262117
] 

Chia-Ping Tsai edited comment on HBASE-19092 at 11/22/17 8:02 AM:
------------------------------------------------------------------

{quote}
The alternatives are taking us away from where we want to be – Tags integrated into Cell
– or they require a bunch of retrofit for which we do not have time.
Tag-use by CPs is rare in the scheme of things. An ugly typecast is ok for now I'd say.
{quote}
Currently the only concern from me is that encouraging cp user to use {{ExtendedCell}} may
hurt the philosophy we try to tell cp user - DONT touch the -red button- internal methods
which may corrupt your data.

Perhaps it is time to introduce the {{RawCell}}. All new tag-related methods be added to {{RawCell}}.
If we are ready to put the tags methods in Cell, we can just remove them from {{RawCell}}
as it is a subclass of {{Cell}} - no competability will be broken

{quote}
What you think Anoop Sam John (or Chia-Ping Tsai – are you on vacation still?)
{quote}
busy these days:(


was (Author: chia7712):
{quote}
The alternatives are taking us away from where we want to be – Tags integrated into Cell
– or they require a bunch of retrofit for which we do not have time.
Tag-use by CPs is rare in the scheme of things. An ugly typecast is ok for now I'd say.
{quote}
Currently the only concern from me is that encouraging cp user to use {{ExtendedCell}} may
hurt the philosophy we try to tell cp user - DONT touch the -red button- internal methods
which may corrupt your data.

Perhaps it is time to introduce the {{RawCell}}. All new tag-related methods be added to {{RawCell}}.
If we are ready to put the tags methods in Cell, we can just remove them from {{RawCell}}
as it is a subclass of {{Cell}} - no competability will be broken


> Make Tag IA.LimitedPrivate and expose for CPs
> ---------------------------------------------
>
>                 Key: HBASE-19092
>                 URL: https://issues.apache.org/jira/browse/HBASE-19092
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19092-branch-2.patch, HBASE-19092-branch-2_5.patch, HBASE-19092-branch-2_5.patch,
HBASE-19092.branch-2.0.02.patch, HBASE-19092_001-branch-2.patch, HBASE-19092_001.patch, HBASE-19092_002-branch-2.patch,
HBASE-19092_002.patch, HBASE-19092_3.patch
>
>
> We need to make tags as LimitedPrivate as some use cases are trying to use tags like
timeline server. The same topic was discussed in dev@ and also in HBASE-18995.
> Shall we target this for beta1 - cc [~saint.ack@gmail.com].
> So once we do this all related Util methods and APIs should also move to LimitedPrivate
Util classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message