hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19092) Make Tag IA.LimitedPrivate and expose for CPs
Date Fri, 17 Nov 2017 13:49:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256976#comment-16256976
] 

Chia-Ping Tsai commented on HBASE-19092:
----------------------------------------

bq. So he was of the opinion that since CPs are not using ExtendedCell if we add these APIs
in ExtendedCell it would mean that we need to do a typecast and that is not straightforward.

Indeed, it is not straightforward but it is the best solution now I think. 

bq. Instead have some static methods only. So shall we add getTags(Cell) to the Tag interface
only? Currently Tag is only for specific Tags but lets change it now?
The {{getTags(Cell)}} is in {{PrivateCellUtil}}. Do you mean moving the method to {{Tag}}?
Typecasting the {{Cell}} to {{ExtendedCell}} is enough for cp user if they want to get {{Tag}}
from {{Cell}}. 

> Make Tag IA.LimitedPrivate and expose for CPs
> ---------------------------------------------
>
>                 Key: HBASE-19092
>                 URL: https://issues.apache.org/jira/browse/HBASE-19092
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19092-branch-2.patch, HBASE-19092-branch-2_5.patch, HBASE-19092-branch-2_5.patch,
HBASE-19092.branch-2.0.02.patch, HBASE-19092_001-branch-2.patch, HBASE-19092_001.patch, HBASE-19092_002-branch-2.patch,
HBASE-19092_002.patch
>
>
> We need to make tags as LimitedPrivate as some use cases are trying to use tags like
timeline server. The same topic was discussed in dev@ and also in HBASE-18995.
> Shall we target this for beta1 - cc [~saint.ack@gmail.com].
> So once we do this all related Util methods and APIs should also move to LimitedPrivate
Util classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message