hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-19056) TestCompactionInDeadRegionServer is top of the flakies charts!
Date Wed, 29 Nov 2017 22:59:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271722#comment-16271722

Duo Zhang commented on HBASE-19056:

Thanks for digging in here. So the problem is, if meta is on the same RS then reassign will
bring the RS down since we need to write something to meta and then the RS will find out that
the WAL is broken and abort itself.

Then I'm OK with approach on moving meta first before suspending the RS. But it is weird to
let TestXXXAsyncWal extends TestXXXSyncWal, can we still use Parameterized to run the test?
Or please introduce a base class and then two sub classes for SyncWal and AsyncWal if you
really want to keep the tests in MediumTests.


>  TestCompactionInDeadRegionServer is top of the flakies charts!
> ---------------------------------------------------------------
>                 Key: HBASE-19056
>                 URL: https://issues.apache.org/jira/browse/HBASE-19056
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: stack
>            Assignee: Ted Yu
>         Attachments: 19056.v5.txt
> The test came in recently as part of HBASE-17712 "Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound"
> [~Apache9] when you have a chance, help me out. I was going to just remove the test since
it made no sense to me but then I saw you wrote it  (smile).
> When the region.compact(true); is called on the end, what is supposed to be going on?
> When I trace, the compact is not done because the Region is not writeEnabled (we check
if Region is writeEnabled down in Store before we go ahead and compact). So, I thought the
problem was that the region reference was stale because it came from the rsToSuspend which
had just been killed.
> After a while, I figured that you intend the region reference to be stale so you can
try an append AFTER the WAL has been taken over by WAL splitter.
> But the writeEnabled flag is set so compactions don't run. I tried unsetting this flag
and closed flags and but compaction won't run.
> Was this your intent sir? If so, I'll work w/ it np. Just looking for clarity. Thanks.

This message was sent by Atlassian JIRA

View raw message