hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18925) Need updated mockito for using java optional
Date Thu, 02 Nov 2017 08:13:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235353#comment-16235353
] 

Hudson commented on HBASE-18925:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3984 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3984/])
HBASE-18925 Update mockito dependency from mockito-all:1.10.19 to (appy: rev 71a55dcd6418fbff9fb90b94a855897077ac6e4d)
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestNamespaceQuotaViolationStore.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestStripeCompactionPolicy.java
* (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapred/TestRowCounter.java
* (edit) hbase-metrics/pom.xml
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestCleanerChore.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestHBaseTestingUtility.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestZKProcedureControllers.java
* (edit) hbase-mapreduce/pom.xml
* (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestGroupingTableMapper.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java
* (edit) hbase-examples/pom.xml
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java
* (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromAdmin.java
* (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
* (edit) hbase-examples/src/test/java/org/apache/hadoop/hbase/mapreduce/TestMapReduceExamples.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestCompactor.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestZKProcedure.java
* (edit) src/main/asciidoc/_chapters/unit_testing.adoc
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestCanaryTool.java
* (edit) hbase-server/pom.xml
* (edit) hbase-shaded/hbase-shaded-check-invariants/pom.xml
* (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestMultiTableSnapshotInputFormatImpl.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java
* (edit) hbase-rsgroup/pom.xml
* (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapred/TestGroupingTableMap.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/StatefulStoreMockMaker.java
* (edit) hbase-endpoint/pom.xml
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerRegionSpaceUseReport.java
* (edit) hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java
* (edit) hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/master/balancer/TestRSGroupBasedLoadBalancer.java
* (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapred/TestIdentityTableMap.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/errorhandling/TestTimeoutExceptionInjector.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestLoadIncrementalHFilesSplitRecovery.java
* (edit) hbase-client/pom.xml
* (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java
* (edit) hbase-metrics-api/pom.xml
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestProcedureMember.java
* (edit) hbase-common/pom.xml
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/errorhandling/TestForeignExceptionDispatcher.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionArchiveIOException.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestProcedureCoordinator.java
* (edit) hbase-rest/pom.xml
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableLocator.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestStripeCompactor.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableAccessorNoCluster.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestTableQuotaViolationStore.java
* (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestHTableMultiplexerViaMocks.java
* (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestWALPlayer.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java
* (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdminRetries.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestProcedure.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestDateTieredCompactor.java
* (edit) hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestHttpServer.java
* (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteHTableRetries.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplit.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestFileSystemUtilizationChore.java
* (edit) pom.xml
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/example/TestZooKeeperTableArchiveClient.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/MockMasterServices.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStripeStoreEngine.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
* (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapred/TestDriver.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestTableSpaceQuotaViolationNotifier.java
* (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestMasterSpaceQuotaObserverWithMocks.java
* (edit) hbase-http/pom.xml
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotaViolationPolicyRefresherChore.java


> Need updated mockito for using java optional
> --------------------------------------------
>
>                 Key: HBASE-18925
>                 URL: https://issues.apache.org/jira/browse/HBASE-18925
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Appy
>            Assignee: Appy
>            Priority: Major
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18925.master.001.patch, HBASE-18925.master.002.patch, HBASE-18925.master.002.patch,
HBASE-18925.master.003.patch, HBASE-18925.master.004.patch, HBASE-18925.master.005.patch,
HBASE-18925.master.006.patch, HBASE-18925.master.007.patch, HBASE-18925.master.008.patch,
HBASE-18925.master.009.patch
>
>
> Came up when i was trying to test HBASE-18878.
> It kept failing because mock of RpcCall returned null where return type was Optional<User>.
> Instead, we want it to return Optional.empty(). 
> New mockito versions support this (and other java8 things) - https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2
> We use mockito-all which was last released in Dec2014. However, mockito-core has had
more than 50 releases after that (https://mvnrepository.com/artifact/org.mockito/mockito-core).

> We need to change our deps from mockito-all to mockito-core.
> However that comes with fair breakages, so this is not a simple task of changing pom
files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message