hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Somogyi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
Date Thu, 09 Nov 2017 13:46:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245663#comment-16245663
] 

Peter Somogyi commented on HBASE-18911:
---------------------------------------

Javadoc for Admin#setSplitOrMergeEnabled links to splitOrMergeEnabledSwitch which you removed,
modify it to splitSwitch and mergeSwitch.

Admin#isSplitOrMergeEnabled typo: Unsupport -> Unsupported
splitOrMergeEnabledSwitch replaced without deprecation, was added recently (2.0.0) so should
be fine?

RawAsyncHBaseAdmin wildcard imports

Good that you added TestInterfaceAlign!
TestInterfaceAlign's license text is not well formed.


> Unify Admin and AsyncAdmin's methods name
> -----------------------------------------
>
>                 Key: HBASE-18911
>                 URL: https://issues.apache.org/jira/browse/HBASE-18911
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18911.master.001.patch
>
>
> Different Methods
> || AsyncAdmin || Admin || unified name ||
> | listTables | listTableDescriptors | listTableDescriptors |
> | getOnlineRegions | getRegions | getRegions |
> | getTableRegions | getRegions | getRegions |
> | getTableDescriptor | getDescriptor | getDescriptor |
> | getRegionLoads | getRegionLoad | getRegionLoads |
> | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn |
> | setNormalizerOn | normalizerSwitch | normalizerSwitch |
> | isNormalizerOn | isNormalizerEnabled | isNormalizerEnabled |
> | setBalancerOn | balancerSwitch | balancerSwitch |
> | isBalancerOn | isBalancerEnabled | isBalancerEnabled |
> | setCleanerChoreOn | cleanerChoreSwitch | cleanerChoreSwitch |
> | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreEnabled |
> | setCatalogJanitorOn | catalogJanitorSwitch | catalogJanitorSwitch |
> | isCatalogJanitorOn | isCatalogJanitorEnabled | isCatalogJanitorEnabled |
> | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | splitSwitch/mergeSwitch |
> | isSplitOn/isMergeOn| isSplitOrMergeEnabled | isSplitEnabled/isMergeEnabled |
> Methods only in AsyncAdmin
> || AsyncAdmin ||
> | majorCompactRegionServer |
> | getMaster |
> | getBackupMasters |
> | getRegionServers |
> Methods only in Admin
> || Admin ||
> | listTableDescriptorsByNamespace |
> | listTableNamesByNamespace |
> | modifyTable |
> | getMasterCoprocessors |



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message