hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Somogyi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16137) Fix findbugs warning introduced by hbase-14730
Date Wed, 22 Nov 2017 09:55:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262229#comment-16262229
] 

Peter Somogyi commented on HBASE-16137:
---------------------------------------

A fix which was previously applied used a synchronized block for the assignment but that caused
significant performance problem. It was removed becayse worst case we'd just get multiple
log messages.
{noformat}
// Reads/writes from/to WARN_CELL_WITH_TAGS aren't thread-safe, but this
// is of limited concern because it should only result in limited extra logging
{noformat}
I'm closing this as the findbugs warning was already disabled.

> Fix findbugs warning introduced by hbase-14730
> ----------------------------------------------
>
>                 Key: HBASE-16137
>                 URL: https://issues.apache.org/jira/browse/HBASE-16137
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.2.0, 1.3.0
>            Reporter: huaxiang sun
>            Assignee: Peter Somogyi
>            Priority: Minor
>
> From stack:
> "Lads. This patch makes for a new findbugs warning: https://builds.apache.org/job/PreCommit-HBASE-Build/2390/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
> If you are good w/ the code, i can fix the findbugs warning... just say."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message