hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-15563) 'counter' may overflow in BoundedGroupingStrategy
Date Thu, 09 Nov 2017 00:52:01 GMT

     [ https://issues.apache.org/jira/browse/HBASE-15563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Purtell updated HBASE-15563:
-----------------------------------
    Fix Version/s:     (was: 1.4.0)

> 'counter' may overflow in BoundedGroupingStrategy
> -------------------------------------------------
>
>                 Key: HBASE-15563
>                 URL: https://issues.apache.org/jira/browse/HBASE-15563
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Duo Zhang
>            Assignee: Matt Warhaftig
>            Priority: Minor
>              Labels: beginner
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: hbase-15563-v1.patch, hbase-15563-v2.patch
>
>
> {code}
> groupName = groupNames[counter.getAndIncrement() % groupNames.length];
> {code}
> Theoretically, counter can overflow and becomes negative then causes an ArrayIndexOutOfBoundsException.
> But in practice, we need 2 billions different identifiers to make this happen, and before
the overflow we will run into OOM because of a huge groupNameCache...
> So not sure if it is worth to fix



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message