Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 28 Oct 2017 01:42:01 +0000 (UTC)
From: "Andrew Purtell (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13110730.1508434094000.84757.1509154921659@Atlassian.JIRA>
In-Reply-To: <JIRA.13110730.1508434094000@Atlassian.JIRA>
References: <JIRA.13110730.1508434094000@Atlassian.JIRA> <JIRA.13110730.1508434094817@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize
 CellComparatorImpl class in branch-1.x
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 28 Oct 2017 01:42:10 -0000


    [ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223139#comment-16223139 ] 

Andrew Purtell commented on HBASE-19052:
----------------------------------------

Yes. I don't understand how we can't be backwards compatible in 2.0 and up, rather than forwards compatible from somewhere in 1.x. 

Double upgrade to latest 1.x then to 2.0 is a shit thing to require of an operator. Let's avoid it. 

> FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x
> ------------------------------------------------------------------------
>
>                 Key: HBASE-19052
>                 URL: https://issues.apache.org/jira/browse/HBASE-19052
>             Project: HBase
>          Issue Type: Improvement
>          Components: HFile
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Critical
>             Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13
>
>         Attachments: 19052.branch-1.txt
>
>
> HBASE-18945 has gone into branch-2 .
> Let's consider rolling upgrade scenario from 1.x to 2.0 where there're three servers: s1, s2, s3
> s1 is upgraded to 2.0 first. It flushes to hfile in region r1 with CellComparatorImpl written in the hfile trailer.
> Somehow s1 crashes and master assigns r1 to s2 which is still running 1.x
> The following code in FixedFileTrailer would be triggered:
> {code}
>       try {
>         comparatorKlass = (Class<? extends CellComparator>) Class.forName(comparatorClassName);
>       } catch (ClassNotFoundException e) {
>         throw new IOException(e);
>       }
> {code}
> since s2 is not aware of CellComparatorImpl.
> This issue is to backport CellComparatorImpl related change to branch-1.x
> Note: CellComparatorImpl wouldn't be used in write path, only in read path.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)