Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CA3A1200D35 for ; Tue, 24 Oct 2017 06:15:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C8CDB160BF0; Tue, 24 Oct 2017 04:15:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1A83A1609E0 for ; Tue, 24 Oct 2017 06:15:07 +0200 (CEST) Received: (qmail 31810 invoked by uid 500); 24 Oct 2017 04:15:07 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 31799 invoked by uid 99); 24 Oct 2017 04:15:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Oct 2017 04:15:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 758FF1A1357 for ; Tue, 24 Oct 2017 04:15:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id DSpWDR-140NT for ; Tue, 24 Oct 2017 04:15:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 124285FCA7 for ; Tue, 24 Oct 2017 04:15:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 09EC1E0D4E for ; Tue, 24 Oct 2017 04:15:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1119321EEB for ; Tue, 24 Oct 2017 04:15:03 +0000 (UTC) Date: Tue, 24 Oct 2017 04:15:03 +0000 (UTC) From: "Peter Somogyi (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-19029) Align RPC timout methods in Table and AsyncTableBase MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 24 Oct 2017 04:15:08 -0000 [ https://issues.apache.org/jira/browse/HBASE-19029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216268#comment-16216268 ] Peter Somogyi commented on HBASE-19029: --------------------------------------- [~Apache9], I fixed your comments. Could you check it? > Align RPC timout methods in Table and AsyncTableBase > ---------------------------------------------------- > > Key: HBASE-19029 > URL: https://issues.apache.org/jira/browse/HBASE-19029 > Project: HBase > Issue Type: Sub-task > Components: asyncclient, Client > Affects Versions: 2.0.0-alpha-3 > Reporter: Peter Somogyi > Assignee: Peter Somogyi > Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19029.master.001.patch, HBASE-19029.master.002.patch, HBASE-19029.master.002.patch, HBASE-19029.master.003.patch, HBASE-19029.master.003.patch, HBASE-19029.master.003.patch > > > Table and AsyncTableBase have similar RPC timeout methods but the async version supports TimeUtils to be passed. > To align these 2 interfaces lets depricate the existing methods in Table and add the ones that are currently in AsyncTableBase. > These methods are the following: > * long getRpcTimeout(TimeUnit unit) > * long getReadRpcTimeout(TimeUnit unit) > * long getWriteRpcTimeout(TimeUnit unit) > * long getOperationTimeout(TimeUnit unit) > We do not have {{long getScanTimeout(TimeUnit unit)}} since scan is handled differently. -- This message was sent by Atlassian JIRA (v6.4.14#64029)