Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 24754200D20 for ; Tue, 17 Oct 2017 15:44:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 226A71609EB; Tue, 17 Oct 2017 13:44:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 689B91609DE for ; Tue, 17 Oct 2017 15:44:04 +0200 (CEST) Received: (qmail 50565 invoked by uid 500); 17 Oct 2017 13:44:03 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 50554 invoked by uid 99); 17 Oct 2017 13:44:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Oct 2017 13:44:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D152D180647 for ; Tue, 17 Oct 2017 13:44:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 2ty1iXK9_L4y for ; Tue, 17 Oct 2017 13:44:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C94555F569 for ; Tue, 17 Oct 2017 13:44:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 69F8CE00B3 for ; Tue, 17 Oct 2017 13:44:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2109E2430F for ; Tue, 17 Oct 2017 13:44:00 +0000 (UTC) Date: Tue, 17 Oct 2017 13:44:00 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-19007) Align Services Interfaces in Master and RegionServer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 17 Oct 2017 13:44:05 -0000 [ https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207653#comment-16207653 ] Anoop Sam John commented on HBASE-19007: ---------------------------------------- Generally I like and agree to the idea of not expose the RSS or MS at all directly.. The methods here which we have to expose to CPs to be added to the *CPEnvironment. Internally the environment classes get these functions from the RSS or MS. Ya our own CPs is a problem maker in this cleanup effort. These clearly suggests we must impl them as core functions (AC, VC etc) For temp what we can do is type cast the environment objects to impl classes and get the RSS or MS from it. In any CP like AC, we get RegionCoprocessorEnvironment. RegionEnvironment re = (RegionEnvironment)rce re.getRegionServerServices() and make use of the functions.. This will be the most simple way even though it look ugly. > Align Services Interfaces in Master and RegionServer > ---------------------------------------------------- > > Key: HBASE-19007 > URL: https://issues.apache.org/jira/browse/HBASE-19007 > Project: HBase > Issue Type: Task > Reporter: stack > Priority: Blocker > Attachments: HBASE-19007.master.001.patch > > > HBASE-18183 adds a CoprocessorRegionServerService to give a view on RegionServiceServices that is safe to expose to Coprocessors. > On the Master-side, MasterServices becomes an Interface for exposing to Coprocessors. > We need to align the two. > For background, see https://issues.apache.org/jira/browse/HBASE-12260?focusedCommentId=16203820&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16203820 -- This message was sent by Atlassian JIRA (v6.4.14#64029)