Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 18 Oct 2017 09:09:00 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13109138.1507866022000.24943.1508317740452@Atlassian.JIRA>
In-Reply-To: <JIRA.13109138.1507866022000@Atlassian.JIRA>
References: <JIRA.13109138.1507866022000@Atlassian.JIRA> <JIRA.13109138.1507866022404@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-19001) Remove the hooks in RegionObserver
 which are designed to construct a StoreScanner which is marked as
 IA.Private
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 18 Oct 2017 09:09:06 -0000


    [ https://issues.apache.org/jira/browse/HBASE-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209023#comment-16209023 ] 

Hudson commented on HBASE-19001:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3908 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3908/])
HBASE-19001 Remove the hooks in RegionObserver which are designed to (zhangduo: rev e804dd0b600f898f7519dee7134b68ad04c20a9a)
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorScanPolicy.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFlusher.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedStoreScanner.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HMobStore.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/NoOpScanPolicyObserver.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/SimpleRegionObserver.java
* (add) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSideScanExcpetionWithCoprocessor.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAvoidCellReferencesIntoShippedBlocks.java
* (add) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/DelegatingInternalScanner.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* (add) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSideScanExcpetion.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java


> Remove the hooks in RegionObserver which are designed to construct a StoreScanner which is marked as IA.Private
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-19001
>                 URL: https://issues.apache.org/jira/browse/HBASE-19001
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-19001-v1.patch, HBASE-19001-v2.patch, HBASE-19001.patch
>
>
> There are three methods here
> {code}
> KeyValueScanner preStoreScannerOpen(ObserverContext<RegionCoprocessorEnvironment> c,
>       Store store, Scan scan, NavigableSet<byte[]> targetCols, KeyValueScanner s, long readPt)
>       throws IOException;
> InternalScanner preFlushScannerOpen(ObserverContext<RegionCoprocessorEnvironment> c,
>       Store store, List<KeyValueScanner> scanners, InternalScanner s, long readPoint)
>       throws IOException;
> InternalScanner preCompactScannerOpen(ObserverContext<RegionCoprocessorEnvironment> c,
>       Store store, List<? extends KeyValueScanner> scanners, ScanType scanType, long earliestPutTs,
>       InternalScanner s, CompactionLifeCycleTracker tracker, CompactionRequest request,
>       long readPoint) throws IOException;
> {code}
> For the flush and compact ones, we've discussed many times, it is not safe to let user inject a Filter or even implement their own InternalScanner using the store file scanners, as our correctness highly depends on the complicated logic in SQM and StoreScanner. CP users are expected to wrap the original InternalScanner(it is a StoreScanner anyway) in preFlush/preCompact methods to do filtering or something else.
> For preStoreScannerOpen it even returns a KeyValueScanner which is marked as IA.Private... This is less hurt but still, we've decided to not expose StoreScanner to CP users so here this method is useless. CP users can use preGetOp and preScannerOpen method to modify the Get/Scan object passed in to inject into the scan operation.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)