Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 11 Oct 2017 13:55:00 +0000 (UTC)
From: "Xiang Li (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13108579.1507724195000.28165.1507730100718@Atlassian.JIRA>
In-Reply-To: <JIRA.13108579.1507724195000@Atlassian.JIRA>
References: <JIRA.13108579.1507724195000@Atlassian.JIRA> <JIRA.13108579.1507724195327@jira-lw-us.apache.org>
Subject: [jira] [Updated] (HBASE-18986) Remove unnecessary null check after
 CellUtil.cloneQualifier()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 11 Oct 2017 13:55:05 -0000


     [ https://issues.apache.org/jira/browse/HBASE-18986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xiang Li updated HBASE-18986:
-----------------------------
    Status: Open  (was: Patch Available)

> Remove unnecessary null check after CellUtil.cloneQualifier()
> -------------------------------------------------------------
>
>                 Key: HBASE-18986
>                 URL: https://issues.apache.org/jira/browse/HBASE-18986
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Xiang Li
>            Assignee: Xiang Li
>            Priority: Minor
>         Attachments: HBASE-18986.master.000.patch
>
>
> In master branch,
> {code:title=hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java|borderStyle=solid}
> // From line 2858
> public void prepareDeleteTimestamps(Mutation mutation, Map<byte[], List<Cell>> familyMap,
>       byte[] byteNow) throws IOException {
>     for (Map.Entry<byte[], List<Cell>> e : familyMap.entrySet()) {
>       // ...
>       for (int i=0; i < listSize; i++) {
>         // ...
>         if (cell.getTimestamp() == HConstants.LATEST_TIMESTAMP && CellUtil.isDeleteType(cell)) {
>           byte[] qual = CellUtil.cloneQualifier(cell);
>           if (qual == null) qual = HConstants.EMPTY_BYTE_ARRAY; // <-- here
>           ...
> {code}
> Might {{if (qual == null) qual = HConstants.EMPTY_BYTE_ARRAY;}} be removed?
> Could it be null after CellUtil.cloneQualifier()?
> {code:title=hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java|borderStyle=solid}
> public static byte[] cloneQualifier(Cell cell){
>   byte[] output = new byte[cell.getQualifierLength()];
>   copyQualifierTo(cell, output, 0);
>   return output;
> }
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)