Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 10 Oct 2017 03:46:03 +0000 (UTC)
From: "Duo Zhang (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13107530.1507302382000.14278.1507607163035@Atlassian.JIRA>
In-Reply-To: <JIRA.13107530.1507302382000@Atlassian.JIRA>
References: <JIRA.13107530.1507302382000@Atlassian.JIRA> <JIRA.13107530.1507302382072@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-18957) add test that confirms 2
 FamilyFilters in a FilterList using MUST_PASS_ONE operator will return
 results that match either of the FamilyFilters and revert as needed to make
 it pass.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 10 Oct 2017 03:46:09 -0000


    [ https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198118#comment-16198118 ] 

Duo Zhang commented on HBASE-18957:
-----------------------------------

The commits you reverted aim to fix other strange behaviors. IIRC, in a FilterList with OR, if one filter returns NEXT_COLUMN and another returns INCLUDE, is it valid to still passes the cells from same column to the filter which returns NEXT_COLUMN?

And for now, NEXT_ROW is ambiguous as a filter will be shared across multiple StoreScanners, and we will only bypass the current family when NEXT_ROW , so a filter can still receive the cells from the same row but another family. How do we want to solve this problem?

Thanks.

> add test that confirms 2 FamilyFilters in a FilterList using MUST_PASS_ONE operator will return results that match either of the FamilyFilters and revert as needed to make it pass.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18957
>                 URL: https://issues.apache.org/jira/browse/HBASE-18957
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Filters
>            Reporter: Sean Busbey
>            Assignee: Peter Somogyi
>            Priority: Critical
>             Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13, 2.0.0-alpha-4
>
>         Attachments: HBASE-18957-branch-1.2.v0.patch, HBASE-18957-branch-1.2.v1.patch, HBASE-18957-branch-1.4.v1.patch, HBASE-18957-branch-1.v1.patch, HBASE-18957-master.v1.patch
>
>
> we need a test that shows the expected behavior for filter lists that rely on OR prior to our filterlist improvements so we have a baseline to show compatibility (and/or document incompatibilities that end up being introduced).
> Specifically (paraphrased from HBASE-18368 description): Using 2 FamilyFilters in a FilterList using MUST_PASS_ONE operator should return results that match either of the FamilyFilters.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)