Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 17 Oct 2017 17:53:00 +0000 (UTC)
From: "ramkrishna.s.vasudevan (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13107132.1507179813000.18297.1508262780823@Atlassian.JIRA>
In-Reply-To: <JIRA.13107132.1507179813000@Atlassian.JIRA>
References: <JIRA.13107132.1507179813000@Atlassian.JIRA> <JIRA.13107132.1507179813952@jira-lw-us.apache.org>
Subject: [jira] [Updated] (HBASE-18945) Make a IA.LimitedPrivate interface
 for CellComparator
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 17 Oct 2017 17:53:06 -0000


     [ https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ramkrishna.s.vasudevan updated HBASE-18945:
-------------------------------------------
      Resolution: Fixed
    Hadoop Flags: Reviewed
          Status: Resolved  (was: Patch Available)

Pushed to master and branch-2. Thanks for all the reviews. The latest failures are time out related issues.

> Make a IA.LimitedPrivate interface for CellComparator
> -----------------------------------------------------
>
>                 Key: HBASE-18945
>                 URL: https://issues.apache.org/jira/browse/HBASE-18945
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-18495.patch, HBASE-18945_2.patch, HBASE-18945_3.patch, HBASE-18945_4.patch, HBASE-18945_5.patch, HBASE-18945_6.patch, HBASE-18945_6.patch, HBASE-18945_7.patch
>
>
> Based on discussions over in HBASE-18826 and HBASE-18183 it is better we expose CellComparator as a public interface so that it could be used in Region/Store interfaces to be exposed to CPs.
> Currently the Comparator is exposed in Region, STore and StoreFile. There is another discussion whether to expose it at all layers or only at Region. However since we are exposing this to CPs CellComparator being @Private is not the ideal way to do it. We have to change it to LimitedPrivate. But CellComparator has lot of additional methods which are internal (like where a Cell is compared with an incoming byte[] used in index comparsions etc).
> One way to expose is that as being done now in HBASE-18826 - by exposing the return type as Comparator<Cell>. But this is not powerful. It only allows to compare cells. So we try to expose an IA.LimitedPrivate interface that is more powerful and allows comparing individual cell components also. 


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)