Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 66773200D37 for ; Thu, 5 Oct 2017 02:55:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 64C0A1609DD; Thu, 5 Oct 2017 00:55:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id ABA6D160BD7 for ; Thu, 5 Oct 2017 02:55:07 +0200 (CEST) Received: (qmail 94662 invoked by uid 500); 5 Oct 2017 00:55:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 94641 invoked by uid 99); 5 Oct 2017 00:55:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Oct 2017 00:55:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DDCFB1A27F1 for ; Thu, 5 Oct 2017 00:55:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 3K-St8XBnk60 for ; Thu, 5 Oct 2017 00:55:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 14BA25FC99 for ; Thu, 5 Oct 2017 00:55:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 534FDE0E18 for ; Thu, 5 Oct 2017 00:55:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5C37424341 for ; Thu, 5 Oct 2017 00:55:00 +0000 (UTC) Date: Thu, 5 Oct 2017 00:55:00 +0000 (UTC) From: "Appy (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References:

Subject: [jira] [Commented] (HBASE-18926) Cleanup Optional from method params MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 05 Oct 2017 00:55:08 -0000 [ https://issues.apache.org/jira/browse/HBASE-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192312#comment-16192312 ] Appy commented on HBASE-18926: ------------------------------ We can change api *after* beta1. So either way, should be okay to fix in beta1, no? > Cleanup Optional from method params > -------------------------------------- > > Key: HBASE-18926 > URL: https://issues.apache.org/jira/browse/HBASE-18926 > Project: HBase > Issue Type: Improvement > Reporter: Appy > Assignee: Duo Zhang > > ref: Discussion on HBASE-18878 > tldr: Optional is not supposed to be used in method params or class fields (http://dolszewski.com/java/java-8-optional-use-cases/). We are doing that in some places. Let's revert that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)