Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3448E200D2F for ; Wed, 18 Oct 2017 01:31:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 32F4A160BEA; Tue, 17 Oct 2017 23:31:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 78BA71609EB for ; Wed, 18 Oct 2017 01:31:07 +0200 (CEST) Received: (qmail 78474 invoked by uid 500); 17 Oct 2017 23:31:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 78456 invoked by uid 99); 17 Oct 2017 23:31:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Oct 2017 23:31:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E0ECBC40D0 for ; Tue, 17 Oct 2017 23:31:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id BrPN4dUbQYSL for ; Tue, 17 Oct 2017 23:31:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 25BB15F3E3 for ; Tue, 17 Oct 2017 23:31:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 72438E0F18 for ; Tue, 17 Oct 2017 23:31:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C2D0224397 for ; Tue, 17 Oct 2017 23:31:02 +0000 (UTC) Date: Tue, 17 Oct 2017 23:31:02 +0000 (UTC) From: "Josh Elser (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18906) Investigate Phoenix usages of Region#waitForXXX APIs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 17 Oct 2017 23:31:08 -0000 [ https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208595#comment-16208595 ] Josh Elser commented on HBASE-18906: ------------------------------------ bq. Maybe a shruggie would have been better. No desire to comment further. Understood, Andrew. Sorry for bringing you back in again. bq. I am not looking to defend against an adversarial questioning of what Phoenix might or might not be doing. I admit it's a bit unfair for me to bring this frustration to this issue where there is missing context, so I apologize for that. I was definitely not trying to be argumentative here (sorry if I came across that way), just come up with a minimum set of things that would make sense to get into alpha-4 and not let scope creep more. Your consideration on good API design from the HBase POV (and the consideration for those downstream) is greatly appreciated by me. > Investigate Phoenix usages of Region#waitForXXX APIs > ---------------------------------------------------- > > Key: HBASE-18906 > URL: https://issues.apache.org/jira/browse/HBASE-18906 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 2.0.0-alpha-4 > > > While reviewing HBASE-18183, Andy pointed out that Phoenix uses waitForFlushesAndCompactions and/or waitForFlushes for diff reasons. This issue is to see why they need them and whether alternate ways are possible. This seems to be too much internal stuff and a normal CP hook calling these would be dangerous. > If there are alternate ways for Phoenix not to use this and not landing in issues (As said by Andy) we should suggest/fix for them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)