Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 82D65200D24 for ; Tue, 24 Oct 2017 21:53:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 815E8160BF1; Tue, 24 Oct 2017 19:53:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CA31C1609C8 for ; Tue, 24 Oct 2017 21:53:04 +0200 (CEST) Received: (qmail 98130 invoked by uid 500); 24 Oct 2017 19:53:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 98119 invoked by uid 99); 24 Oct 2017 19:53:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Oct 2017 19:53:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3760C18077F for ; Tue, 24 Oct 2017 19:53:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id VkkVg2m223xy for ; Tue, 24 Oct 2017 19:53:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 56D265FDBE for ; Tue, 24 Oct 2017 19:53:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 11B47E00C9 for ; Tue, 24 Oct 2017 19:53:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7264621302 for ; Tue, 24 Oct 2017 19:53:00 +0000 (UTC) Date: Tue, 24 Oct 2017 19:53:00 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18905) Allow CPs to request flush on Region and know the completion of the requested flush MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 24 Oct 2017 19:53:05 -0000 [ https://issues.apache.org/jira/browse/HBASE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217571#comment-16217571 ] stack commented on HBASE-18905: ------------------------------- bq. Just want to follow the other methods below, beforeExecution and afterExecution. And the word 'fail' may give users an impression that something serious is happened, but here it usually only means that there is already a flush ongoing. Ok. > Allow CPs to request flush on Region and know the completion of the requested flush > ----------------------------------------------------------------------------------- > > Key: HBASE-18905 > URL: https://issues.apache.org/jira/browse/HBASE-18905 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors > Reporter: Anoop Sam John > Assignee: Duo Zhang > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18905.patch, HBASE-18905.patch > > > Follow up for HBASE-18183 > As per that Jira, we keep only requestCompaction API in Region. We did not have any such for flush in Region. Only API which was there is a flush which will block the callee unless flush is done. This issue has to tacke > 1. Decide whether we need a requestFlush in Region and if so add > 2. Whether the requestCompaction (And requestFlush too) should return a Future? Right now the former do not return any but allow to pass a CompactionLifeCycleTracker which will get notified on start and end of compaction. -- This message was sent by Atlassian JIRA (v6.4.14#64029)