Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 26FB1200D28 for ; Mon, 23 Oct 2017 23:19:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 259ED160BF0; Mon, 23 Oct 2017 21:19:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6A8041609DF for ; Mon, 23 Oct 2017 23:19:03 +0200 (CEST) Received: (qmail 55444 invoked by uid 500); 23 Oct 2017 21:19:02 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 55433 invoked by uid 99); 23 Oct 2017 21:19:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Oct 2017 21:19:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D5FF8C1E7F for ; Mon, 23 Oct 2017 21:19:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id EMEJnzMlyoEV for ; Mon, 23 Oct 2017 21:19:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1D60B60DC4 for ; Mon, 23 Oct 2017 21:19:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9C1EDE0E29 for ; Mon, 23 Oct 2017 21:19:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 56E8C24360 for ; Mon, 23 Oct 2017 21:19:00 +0000 (UTC) Date: Mon, 23 Oct 2017 21:19:00 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18873) Hide protobufs in GlobalQuotaSettings MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 23 Oct 2017 21:19:04 -0000 [ https://issues.apache.org/jira/browse/HBASE-18873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215865#comment-16215865 ] stack commented on HBASE-18873: ------------------------------- Seems fine to me. Release note on how to get listing from here on out would be sweet. Thanks [~elserj] > Hide protobufs in GlobalQuotaSettings > ------------------------------------- > > Key: HBASE-18873 > URL: https://issues.apache.org/jira/browse/HBASE-18873 > Project: HBase > Issue Type: Sub-task > Reporter: Josh Elser > Assignee: Josh Elser > Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18873.001.branch-2.patch, HBASE-18873.002.branch-2.patch, HBASE-18873.003.branch-2.patch > > > HBASE-18807 cleaned up direct protobuf use in the Coprocessor APIs for quota-related functions. However, one new POJO introduced to hide these protocol buffers still exposes PBs via some methods. > We should try to hide those as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)