Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 21 Oct 2017 23:56:03 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13102461.1505448349000.28359.1508630163434@Atlassian.JIRA>
In-Reply-To: <JIRA.13102461.1505448349000@Atlassian.JIRA>
References: <JIRA.13102461.1505448349000@Atlassian.JIRA> <JIRA.13102461.1505448349927@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-18824) Add meaningful comment to
 HConstants.LATEST_TIMESTAMP to explain why it is MAX_VALUE
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Sat, 21 Oct 2017 23:56:12 -0000


    [ https://issues.apache.org/jira/browse/HBASE-18824?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D162=
14133#comment-16214133 ]=20

Hudson commented on HBASE-18824:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3927 (See [https:/=
/builds.apache.org/job/HBase-Trunk_matrix/3927/])
HBASE-18824 Add meaningful comment to HConstants.LATEST_TIMESTAMP to (chia7=
712: rev 2ee8690b47763fd0ed97d47713b1c516633f597b)
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java


> Add meaningful comment to HConstants.LATEST_TIMESTAMP to explain why it i=
s MAX_VALUE
> -------------------------------------------------------------------------=
-----------
>
>                 Key: HBASE-18824
>                 URL: https://issues.apache.org/jira/browse/HBASE-18824
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Xiang Li
>            Assignee: Xiang Li
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-18824.master.000.patch, HBASE-18824.master.001=
.patch, HBASE-18824.master.002.patch, HBASE-18824.master.003.patch, HBASE-1=
8824.master.004.patch, HBASE-18824.master.005.patch
>
>
> Thanks to [Jerry and Chia-Ping Tsai's comments|https://issues.apache.org/=
jira/browse/HBASE-18824?focusedCommentId=3D16167392&page=3Dcom.atlassian.ji=
ra.plugin.system.issuetabpanels:comment-tabpanel#comment-16167392] to corre=
ct my wrong understanding.=20
> The following documentation says that by default(when the timestamp is no=
t specified for Put or Delete), system uses the server's {{currentTimeMilli=
s}}.
> 1. In chapter 27.2.4 Put=20
> bq. Doing a put always creates a new version of a cell, at a certain time=
stamp. {color:#205081}By default the system uses the server=E2=80=99s curre=
ntTimeMillis{color}, ...
> 2. In chapter 27.2.5 Delete
> bq. Deletes work by creating tombstone markers. For example, let=E2=80=99=
s suppose we want to delete a row. For this you can specify a version, or e=
lse {color:#205081}by default the currentTimeMillis is used.{color}...
> It seems not consistent with the code. Because in the client side's code,=
 when timestamp is not specified, HConstants.LATEST_TIMESTAMP is used, whic=
h is Long.MAX_VALUE, rather than {{System.currentTimeMillis()}}.
> However, the documentation is correct, because on the server side,  times=
tamp of Put cell with HConstants.LATEST_TIMESTAMP will be replaced with ser=
ver's {{currentTimeMillis}}.
> So we decide to add more comments to HConstants.LATEST_TIMESTAMP to help =
the new comers steer clear of the confusion.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)