Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 31 Oct 2017 10:25:00 +0000 (UTC)
From: "Wang, Xinglong (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13094748.1502800422000.109677.1509445500747@Atlassian.JIRA>
In-Reply-To: <JIRA.13094748.1502800422000@Atlassian.JIRA>
References: <JIRA.13094748.1502800422000@Atlassian.JIRA> <JIRA.13094748.1502800422265@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-18602) rsgroup cleanup unassign code
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 31 Oct 2017 10:25:06 -0000


    [ https://issues.apache.org/jira/browse/HBASE-18602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226567#comment-16226567 ] 

Wang, Xinglong commented on HBASE-18602:
----------------------------------------

[~chia7712] Thanks for merging the code.

> rsgroup cleanup unassign code
> -----------------------------
>
>                 Key: HBASE-18602
>                 URL: https://issues.apache.org/jira/browse/HBASE-18602
>             Project: HBase
>          Issue Type: Improvement
>          Components: rsgroup
>            Reporter: Wang, Xinglong
>            Assignee: Wang, Xinglong
>            Priority: Minor
>             Fix For: 2.0.0, 1.4.0, 1.5.0
>
>         Attachments: HBASE-18602-master-v1.patch, HBASE-18602-master-v2.patch, HBASE-18602-master-v3.patch, HBASE-18602-master-v3.patch, HBASE-18602-master-v3.patch, HBASE-18602-master-v4.patch
>
>
> While walking through rsgroup code, I found that variable misplacedRegions has never been added any element into. This makes the unassign region code is not functional. And according to my test, it is actually unnecessary to do that.
> RSGroupBasedLoadBalancer.java
> {code:java}
> private Map<ServerName, List<HRegionInfo>> correctAssignments(
>        Map<ServerName, List<HRegionInfo>> existingAssignments)
>   throws HBaseIOException{
>     Map<ServerName, List<HRegionInfo>> correctAssignments = new TreeMap<>();
>     List<HRegionInfo> misplacedRegions = new LinkedList<>();
>     correctAssignments.put(LoadBalancer.BOGUS_SERVER_NAME, new LinkedList<>());
>     for (Map.Entry<ServerName, List<HRegionInfo>> assignments : existingAssignments.entrySet()){
>       ServerName sName = assignments.getKey();
>       correctAssignments.put(sName, new LinkedList<>());
>       List<HRegionInfo> regions = assignments.getValue();
>       for (HRegionInfo region : regions) {
>         RSGroupInfo info = null;
>         try {
>           info = rsGroupInfoManager.getRSGroup(
>               rsGroupInfoManager.getRSGroupOfTable(region.getTable()));
>         } catch (IOException exp) {
>           LOG.debug("RSGroup information null for region of table " + region.getTable(),
>               exp);
>         }
>         if ((info == null) || (!info.containsServer(sName.getAddress()))) {
>           correctAssignments.get(LoadBalancer.BOGUS_SERVER_NAME).add(region);
>         } else {
>           correctAssignments.get(sName).add(region);
>         }
>       }
>     }
>     //TODO bulk unassign?
>     //unassign misplaced regions, so that they are assigned to correct groups.
>     for(HRegionInfo info: misplacedRegions) {
>       try {
>         this.masterServices.getAssignmentManager().unassign(info);
>       } catch (IOException e) {
>         throw new HBaseIOException(e);
>       }
>     }
>     return correctAssignments;
>   }
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)