Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3EBAE200D26 for ; Fri, 20 Oct 2017 22:31:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3D4461609ED; Fri, 20 Oct 2017 20:31:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 811BA160BCB for ; Fri, 20 Oct 2017 22:31:05 +0200 (CEST) Received: (qmail 19737 invoked by uid 500); 20 Oct 2017 20:31:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 19726 invoked by uid 99); 20 Oct 2017 20:31:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Oct 2017 20:31:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 8F06D1A1229 for ; Fri, 20 Oct 2017 20:31:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -98.702 X-Spam-Level: X-Spam-Status: No, score=-98.702 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 2icHK79v1Rw6 for ; Fri, 20 Oct 2017 20:31:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 62EF95FD8E for ; Fri, 20 Oct 2017 20:31:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6B736E0D60 for ; Fri, 20 Oct 2017 20:31:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9240424390 for ; Fri, 20 Oct 2017 20:31:00 +0000 (UTC) Date: Fri, 20 Oct 2017 20:31:00 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17934) Backport HBASE-17779 "disable_table_replication returns misleading message and does not turn off replication" to branch-1.3 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 20 Oct 2017 20:31:06 -0000 [ https://issues.apache.org/jira/browse/HBASE-17934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213183#comment-16213183 ] Hudson commented on HBASE-17934: -------------------------------- FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #314 (See [https://builds.apache.org/job/HBase-1.3-JDK7/314/]) HBASE-17934 Backport HBASE-17779 "disable_table_replication returns (tedyu: rev 6124f9dfec679c378f639e73cd37dd9badb96181) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdminWithClusters.java HBASE-17934 Backport HBASE-17779 "disable_table_replication returns (tedyu: rev 1300faffbc37eb0f3962639efa9ff990e80461ed) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdminWithClusters.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java HBASE-17934 Backport HBASE-17779 "disable_table_replication returns (tedyu: rev ba76330732d11c3a0f4a2c1b0790a30ef589208f) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdminWithClusters.java > Backport HBASE-17779 "disable_table_replication returns misleading message and does not turn off replication" to branch-1.3 > --------------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-17934 > URL: https://issues.apache.org/jira/browse/HBASE-17934 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Janos Gub > Fix For: 1.3.2 > > Attachments: 17934.branch-1.3.patch, 17934.branch-1.3.patch, HBASE-17934.patch > > > Currently HBaseAdmin#isTableRepEnabled() returns false if ANY of the columns families is not replicated. > Because of this if you have a table where replication is partially enabled, calling disable_table_replication will not have any effect, but will report that replication for a given table is disabled. > Workaround is enabling table replication before disabling. > As a solution quoted from HBASE-17460: > Admin#disableTableReplication() returns nothing and isTableRepEnabled() returns boolean. For master branch, we can let isTableRepEnabled() return enum (partially disabled, disabled, etc) This way, Admin#disableTableReplication() can return meaningful value to the user. > This issue is to backport the fix to branch-1.3 -- This message was sent by Atlassian JIRA (v6.4.14#64029)