Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 18 Oct 2017 03:21:00 +0000 (UTC)
From: "Duo Zhang (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12927336.1452021540000.23108.1508296860824@Atlassian.JIRA>
In-Reply-To: <JIRA.12927336.1452021540000@Atlassian.JIRA>
References: <JIRA.12927336.1452021540000@Atlassian.JIRA> <JIRA.12927336.1452021540078@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-15071) Cleanup bypass semantic in
 MasterCoprocessorHost
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 18 Oct 2017 03:21:07 -0000


    [ https://issues.apache.org/jira/browse/HBASE-15071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208760#comment-16208760 ] 

Duo Zhang commented on HBASE-15071:
-----------------------------------

Got it sir.

> Cleanup bypass semantic in MasterCoprocessorHost
> ------------------------------------------------
>
>                 Key: HBASE-15071
>                 URL: https://issues.apache.org/jira/browse/HBASE-15071
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>    Affects Versions: 2.0.0
>            Reporter: stack
>            Assignee: Umesh Agashe
>            Priority: Blocker
>         Attachments: HBASE-15071.patch
>
>
> Lets decide on this one before we release 2.0.0.
> A bunch of methods in MasterCoprocessorHost on the 'pre' step allow returning true which indicates the method invocation is not to proceed.
> Not all 'pre' steps do this. Just some.
> Seems a little arbitrary.
> How we skip out if we are not proceed with the invocation is also a little arbitrary.
> When a deleteColumn call is supposed to skip out, it returns a -1, a non-procId. If we are to skip a balance call, we log that CP said skip and then return false to indicate the balancer did not run (why?). Elsewhere we just exit silently. In createNamespace we used to exit silently but HBASE-14888 just changed it so we throw a BypassCoprocessorException instead... 
> Lets make them all work the same way.
> (This issue comes of chat w/ Matteo)


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)